Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: additional space between pagination bar and components in update log component #3987

Closed
wants to merge 2 commits into from
Closed

fix: additional space between pagination bar and components in update log component #3987

wants to merge 2 commits into from

Conversation

kunatastic
Copy link
Contributor

@kunatastic kunatastic commented Nov 7, 2022 •
edited by aeswibon
Loading

Bug Fix

Proposed Changes

  • Fixed space b/w pagination bar and updated log components

Associated Issue

Screenshot

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@kunatastic kunatastic requested a review from a team November 7, 2022 03:11
@kunatastic kunatastic requested a review from a team as a code owner November 7, 2022 03:11
@vercel
Copy link

vercel bot commented Nov 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 22, 2022 at 8:27AM (UTC)

@netlify
Copy link

netlify bot commented Nov 7, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5971570
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a414b2963706000972a72f
😎 Deploy Preview https://deploy-preview-3987--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022

@kunatastic
image

make it aligned in center

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

👋 Hi, @kunatastic,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Dec 8, 2022

@kunatastic what is the status of the PR

@aeswibon aeswibon added needs testing and removed work-in-progress merge conflict pull requests with merge conflict needs testing labels Dec 17, 2022
@aeswibon
Copy link
Member

@nihal467 I have fixed the alignement issue. This PR is good for testing

@nihal467
Copy link
Member

LGTM @khavinshankar be careful while merging,

@khavinshankar
Copy link
Member

@cp-Coder @kunatastic can you checkout the cypress fails, likely merging the develop branch should fix it

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Dec 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@github-actions
Copy link

👋 Hi, @kunatastic,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 23, 2022
@nihal467
Copy link
Member

nihal467 commented Feb 4, 2023

@khavinshankar @kunatastic can you check the merge conflict

@nihal467
Copy link
Member

nihal467 commented Feb 6, 2023 •
edited
Loading

@khavinshankar clear the merge conflict and mark it for testing

@nihal467 nihal467 added the stale label Feb 6, 2023
@github-actions github-actions bot removed the stale label Feb 7, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 27, 2023 •
edited
Loading

@khavinshankar can you clear the conflict it

@khavinshankar
Copy link
Member

@cp-Coder can you work on the merge conflits ASAP

@aeswibon
Copy link
Member

Closing this PR as the issue has already fixed.
image

@aeswibon aeswibon closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too much whitespace when a log updates list page has too little cards on the current page
5 participants
@kunatastic @nihal467 @aeswibon @khavinshankar @rithviknishad