Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a modal to notify user if a existing triage exist #4008

Merged
merged 9 commits into from
Dec 28, 2022
Merged

Added a modal to notify user if a existing triage exist #4008

merged 9 commits into from
Dec 28, 2022

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

Fixes #3950
Added a modal to notify user if a existing triage exist
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team November 9, 2022 06:32
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner November 9, 2022 06:32
@vercel
Copy link

vercel bot commented Nov 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 24, 2022 at 3:01PM (UTC)

@netlify
Copy link

netlify bot commented Nov 9, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit efcc2b1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a713a4b2ca5900095799be
😎 Deploy Preview https://deploy-preview-4008--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022 •
edited
Loading

@patelaryan7751 the functionality looks good ! but, the text content seem bulky, shall we discuss it on EOD, to see other opinions too !

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022

  • "a triage already exist in the date" can be on first row and move the remaining content to the next line and use smaller font size for that
  • use the tailwind button
  • use the danger or warning exist for the proceed button
  • use secondary for the cancel button

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 all the modal Ui changes are done.
image

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@patelaryan7751 patelaryan7751 removed the merge conflict pull requests with merge conflict label Dec 6, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

LGTM

@nihal467 nihal467 added the tested label Dec 6, 2022
khavinshankar
khavinshankar requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patelaryan7751 some minor changes

src/Components/Common/components/ButtonV2.tsx Outdated Show resolved Hide resolved
src/Components/Facility/TriageForm.tsx Show resolved Hide resolved
src/Components/Facility/TriageForm.tsx Show resolved Hide resolved
src/Components/Facility/TriageForm.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 15, 2022
@github-actions
Copy link

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@netlify
Copy link

netlify bot commented Dec 19, 2022 •
edited
Loading

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 51c4e7b
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63a7090a2b794c00090c8b57

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict and removed merge conflict pull requests with merge conflict labels Dec 19, 2022
@github-actions
Copy link

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@patelaryan7751 can you work on it and push it after fixing all the problems before new year

@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751 patelaryan7751 added needs testing and removed changes required Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict tested labels Dec 24, 2022
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 5c61c18 into coronasafe:develop Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Triage old data is getting replaced with new data in facility
3 participants
@patelaryan7751 @nihal467 @khavinshankar