Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patient Details page redesign #4010

Merged
merged 11 commits into from
Nov 24, 2022
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Nov 9, 2022

Resolves #3931
Resolves #3268

Figma design followed: https://www.figma.com/file/fqDMgeN2m4TCSz5KobZaKW/CoronaSafe-Network-Care?node-id=1237%3A576

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team November 9, 2022 08:57
@Ashesh3 Ashesh3 requested a review from a team as a code owner November 9, 2022 08:57
@Ashesh3 Ashesh3 requested a review from gigincg November 9, 2022 08:57
@vercel
Copy link

vercel bot commented Nov 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 6:19AM (UTC)

@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e2c3f01
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/637c69a30cc63300084342bd
😎 Deploy Preview https://deploy-preview-4010--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad added the Major Code Change This Tag represent PR, which will be causing major Code change in the platform label Nov 9, 2022
@Ashesh3
Copy link
Member Author

Ashesh3 commented Nov 10, 2022

This should also resolve #3268 , can you confirm that @nihal467 ?

@nihal467
Copy link
Member

nihal467 commented Nov 21, 2022

@Ashesh3
image

  • make the created and last edited, tooltip uniform like other sections, the first row shows the user name, the second row shows the user id and the third row shows the role

image

  • make the buttons left-aligned in the responsive view

Untitled

  • does changing the colour of buttons intentional or not ?

@Ashesh3
Copy link
Member Author

Ashesh3 commented Nov 21, 2022

@nihal467 Changes are done. Yes, the button change is intentional since we switched to ButtonV2.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashesh3 you can use the variant="secondary" for the cancel button in the modal.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Nov 22, 2022

@Ashesh3 you can use the variant="secondary" for the cancel button in the modal.

Done!
image

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@nihal467
Copy link
Member

@nihal467
Copy link
Member

@Ashesh3 UI is approved, @khavinshankar you can review and merge it

@khavinshankar khavinshankar merged commit d92686a into coronasafe:develop Nov 24, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
* Patient Detail page redesign

* Add tooltips for displaying the user who created or last edited

* Use CSS tooltips

* Switch to ButtonV2

* Checkout new ButtonV2 with authorizedFor

* Upgrade RoleButtons to ButtonV2

* Replace material-ui icons with unicons

* Make page responsive and bug fixes

* UI Changes

* UI changes

* Change cancel button variant to secondary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Code Change This Tag represent PR, which will be causing major Code change in the platform redesign tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign Patient Page Redesign Patient UI
4 participants