Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the navigation issue in BedManagement #4016

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Fixed the navigation issue in BedManagement #4016

merged 5 commits into from
Nov 17, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • Fixed the navigation issue in BedManagement
    Now going back from Bed Management should take us to Location Management

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team November 9, 2022 14:09
@khavinshankar khavinshankar requested a review from a team as a code owner November 9, 2022 14:09
@vercel
Copy link

vercel bot commented Nov 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 5:38AM (UTC)

@netlify
Copy link

netlify bot commented Nov 9, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 20e1560
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636ddfa071efe200080d721d
😎 Deploy Preview https://deploy-preview-4016--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 9, 2022
@khavinshankar khavinshankar removed the cypress failed pull request with cypress test failure label Nov 10, 2022
@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar removed the cypress failed pull request with cypress test failure label Nov 17, 2022
@gigincg gigincg merged commit b7ecad3 into develop Nov 17, 2022
@gigincg gigincg deleted the fix#3879 branch November 17, 2022 15:30
@khavinshankar khavinshankar mentioned this pull request Nov 23, 2022
Closed
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@khavinshankar @aeswibon
Fixed the navigation issue in BedManagement (coronasafe#4016)
0bc9a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khavinshankar @nihal467 @gigincg