Remove broken pagination and disable inputs on Inventory Management #4028

Ashesh3 · 2022-11-10T15:06:20Z

Proposed Changes

While updating the Minimum Quantity, the Inventory Name is already not editable but not marked as disabled, giving a false sensation that input is allowed to be modified. This PR marks the field as disabled.
Removed broken pagination from Inventory management as it's not used nor needed since under any circumstances there can be at max 7 items in total, so no pagination is needed (and is not implemented).

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

vercel · 2022-11-10T15:06:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
care-storybook	✅ Ready (Inspect)	Visit Preview	Dec 21, 2022 at 5:51AM (UTC)

netlify · 2022-11-10T15:06:29Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`6fbb047`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/63a29e5e23bf2c00097d5bda
😎 Deploy Preview	https://deploy-preview-4028--care-egov-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

nihal467 · 2022-11-16T07:59:57Z

test approved

khavinshankar · 2022-11-16T12:45:14Z

src/Components/Facility/SetInventoryForm.tsx

@@ -175,6 +174,7 @@ export const SetInventoryForm = (props: any) => {
                    type="string"
                    value={currentUnit}
                    errors=""
+                    disabled={true}


If we are setting this as disabled always, why should this be an input field, can we design it better?

It conveys to me that this field was manually set (input) by a user and is no longer editable. More like, "This field is not available for editing". Do you recommend converting it to a plain text?

@khavinshankar any updates on this?

@Ashesh3 can we do something like a badge maybe

@nihal467 what's your take

@khavinshankar Lets take it up in the EOD

khavinshankar · 2022-11-16T12:45:20Z

src/Components/Facility/UpdateMinQuantity.tsx

@@ -149,6 +148,7 @@ export const UpdateMinQuantity = (props: any) => {
                    type="string"
                    value={data}
                    errors=""
+                    disabled={true}


If we are setting this as disabled always, why should this be an input field, can we design it better?

github-actions · 2022-11-17T12:51:01Z

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2022-11-22T12:13:43Z

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2022-12-01T12:48:38Z

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

nihal467 · 2022-12-04T04:49:26Z

@Ashesh3 what is the update on this PR

Ashesh3 · 2022-12-04T04:55:50Z

@Ashesh3 what is the update on this PR

Hey, @khavinshankar mentioned you in the review above and requested your take on what should be done here for inputs. If you could respond there and let me know, i can proceed accordingly.

khavinshankar · 2022-12-04T05:00:19Z

@Ashesh3 what is the update on this PR

Hey, @khavinshankar mentioned you in the review above and requested your take on what should be done here for inputs. If you could respond there and let me know, i can proceed accordingly.

#4028 (comment)

Ashesh3 · 2022-12-07T10:55:27Z

@nihal467 Any updates on this? Please check the conversation above.

nihal467 · 2022-12-13T12:43:05Z

@Ashesh3 @khavinshankar so what are we doing now of this PR

Ashesh3 · 2022-12-13T12:44:19Z

@Ashesh3 @khavinshankar so what are we doing now of this PR

Tried a few different designs, will showcase the modal design tomorrow.

Ashesh3 · 2022-12-18T13:26:19Z

@nihal467 @khavinshankar Thoughts on the new design?

Replaced the page with a modal

khavinshankar · 2022-12-18T14:16:12Z

Looks great, @nihal467 your thoughts?

nihal467 · 2022-12-19T10:31:06Z

@Ashesh3 Looks good to me, marking it for team discussion required for final approval on UI

src/Components/Facility/MinQuantityList.tsx

sonarcloud · 2022-12-21T05:50:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
0.0% Duplication

Ashesh3 requested a review from a team November 10, 2022 15:06

Ashesh3 requested a review from a team as a code owner November 10, 2022 15:06

Ashesh3 requested a review from gigincg November 10, 2022 15:06

Ashesh3 added the needs testing label Nov 10, 2022

vercel bot deployed to Preview November 10, 2022 15:08 View deployment

nihal467 added tested and removed needs testing labels Nov 16, 2022

khavinshankar reviewed Nov 16, 2022

View reviewed changes

khavinshankar added the question Further information is requested label Nov 16, 2022

github-actions bot added the merge conflict pull requests with merge conflict label Nov 17, 2022

Ashesh3 removed question Further information is requested merge conflict pull requests with merge conflict labels Nov 22, 2022

vercel bot deployed to Preview November 22, 2022 04:19 View deployment

github-actions bot added the merge conflict pull requests with merge conflict label Nov 22, 2022

Ashesh3 removed the merge conflict pull requests with merge conflict label Nov 22, 2022

vercel bot deployed to Preview November 22, 2022 12:16 View deployment

khavinshankar added the question Further information is requested label Nov 24, 2022

github-actions bot added the merge conflict pull requests with merge conflict label Dec 1, 2022

nihal467 added the Team Discuss Required label Dec 8, 2022

nihal467 added the waiting for update PR is been dead for a long time label Dec 13, 2022

Move min quantity update page to a modal

b72a545

Ashesh3 force-pushed the issue-4027 branch from ffbf305 to b72a545 Compare December 18, 2022 13:23

vercel bot deployed to Preview December 18, 2022 13:25 View deployment

Ashesh3 added needs testing and removed question Further information is requested tested waiting for update PR is been dead for a long time merge conflict pull requests with merge conflict Team Discuss Required labels Dec 18, 2022

nihal467 added tested Team Discuss Required and removed needs testing Team Discuss Required labels Dec 19, 2022

khavinshankar requested changes Dec 21, 2022

View reviewed changes

src/Components/Facility/MinQuantityList.tsx Outdated Show resolved Hide resolved

khavinshankar added the changes required label Dec 21, 2022

Remove debugging statement

6fbb047

Ashesh3 removed the changes required label Dec 21, 2022

vercel bot deployed to Preview December 21, 2022 05:51 View deployment

Ashesh3 requested review from khavinshankar December 21, 2022 21:50

khavinshankar approved these changes Dec 22, 2022

View reviewed changes

khavinshankar merged commit 5bc7992 into ohcnetwork:develop Dec 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove broken pagination and disable inputs on Inventory Management #4028

Remove broken pagination and disable inputs on Inventory Management #4028

Ashesh3 commented Nov 10, 2022 •

edited

Loading

vercel bot commented Nov 10, 2022 •

edited

Loading

netlify bot commented Nov 10, 2022 •

edited

Loading

nihal467 commented Nov 16, 2022

khavinshankar Nov 16, 2022

Ashesh3 Nov 17, 2022

Ashesh3 Nov 22, 2022

khavinshankar Nov 24, 2022

nihal467 Dec 8, 2022 •

edited

Loading

khavinshankar Nov 16, 2022

github-actions bot commented Nov 17, 2022

github-actions bot commented Nov 22, 2022

github-actions bot commented Dec 1, 2022

nihal467 commented Dec 4, 2022

Ashesh3 commented Dec 4, 2022

khavinshankar commented Dec 4, 2022

Ashesh3 commented Dec 7, 2022

nihal467 commented Dec 13, 2022

Ashesh3 commented Dec 13, 2022

Ashesh3 commented Dec 18, 2022

khavinshankar commented Dec 18, 2022

nihal467 commented Dec 19, 2022

sonarcloud bot commented Dec 21, 2022

Remove broken pagination and disable inputs on Inventory Management #4028

Remove broken pagination and disable inputs on Inventory Management #4028

Conversation

Ashesh3 commented Nov 10, 2022 • edited Loading

Proposed Changes

vercel bot commented Nov 10, 2022 • edited Loading

netlify bot commented Nov 10, 2022 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

nihal467 commented Nov 16, 2022

khavinshankar Nov 16, 2022

Choose a reason for hiding this comment

Ashesh3 Nov 17, 2022

Choose a reason for hiding this comment

Ashesh3 Nov 22, 2022

Choose a reason for hiding this comment

khavinshankar Nov 24, 2022

Choose a reason for hiding this comment

nihal467 Dec 8, 2022 • edited Loading

Choose a reason for hiding this comment

khavinshankar Nov 16, 2022

Choose a reason for hiding this comment

github-actions bot commented Nov 17, 2022

github-actions bot commented Nov 22, 2022

github-actions bot commented Dec 1, 2022

nihal467 commented Dec 4, 2022

Ashesh3 commented Dec 4, 2022

khavinshankar commented Dec 4, 2022

Ashesh3 commented Dec 7, 2022

nihal467 commented Dec 13, 2022

Ashesh3 commented Dec 13, 2022

Ashesh3 commented Dec 18, 2022

khavinshankar commented Dec 18, 2022

nihal467 commented Dec 19, 2022

sonarcloud bot commented Dec 21, 2022

Ashesh3 commented Nov 10, 2022 •

edited

Loading

vercel bot commented Nov 10, 2022 •

edited

Loading

netlify bot commented Nov 10, 2022 •

edited

Loading

nihal467 Dec 8, 2022 •

edited

Loading