-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove broken pagination and disable inputs on Inventory Management #4028
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
test approved |
@@ -175,6 +174,7 @@ export const SetInventoryForm = (props: any) => { | |||
type="string" | |||
value={currentUnit} | |||
errors="" | |||
disabled={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are setting this as disabled always, why should this be an input field, can we design it better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It conveys to me that this field was manually set (input) by a user and is no longer editable. More like, "This field is not available for editing". Do you recommend converting it to a plain text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khavinshankar any updates on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khavinshankar Lets take it up in the EOD
@@ -149,6 +148,7 @@ export const UpdateMinQuantity = (props: any) => { | |||
type="string" | |||
value={data} | |||
errors="" | |||
disabled={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are setting this as disabled always, why should this be an input field, can we design it better?
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@Ashesh3 what is the update on this PR |
Hey, @khavinshankar mentioned you in the review above and requested your take on what should be done here for inputs. If you could respond there and let me know, i can proceed accordingly. |
|
@nihal467 Any updates on this? Please check the conversation above. |
@Ashesh3 @khavinshankar so what are we doing now of this PR |
Tried a few different designs, will showcase the modal design tomorrow. |
@nihal467 @khavinshankar Thoughts on the new design?
|
Looks great, @nihal467 your thoughts? |
@Ashesh3 Looks good to me, marking it for team discussion required for final approval on UI |
Kudos, SonarCloud Quality Gate passed!
|
Fixes #4027
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers