Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with search input accidentally debouncing #4037

Merged
merged 2 commits into from
Nov 12, 2022
Merged

fix issue with search input accidentally debouncing #4037

merged 2 commits into from
Nov 12, 2022

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team November 11, 2022 13:53
@rithviknishad rithviknishad requested a review from a team as a code owner November 11, 2022 13:53
@vercel
Copy link

vercel bot commented Nov 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 5:53PM (UTC)

@netlify
Copy link

netlify bot commented Nov 11, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ed7f66c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636e8b9524a26c00071ebfe3
😎 Deploy Preview https://deploy-preview-4037--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@rithviknishad
image

pagination is still not working

@rithviknishad
Copy link
Member Author

@nihal467 pagination issue is not covered in this PR. This PR just prevents the search input from invoking the debounced onChange

@rithviknishad
Copy link
Member Author

@nihal467 hold. quick fixing it.

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad rithviknishad changed the title fix issue with searcch input accidentally debocuncing fix issue with search input accidentally debouncing Nov 11, 2022
@rithviknishad
Copy link
Member Author

@nihal467 could you check now

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 3bc737c into ohcnetwork:develop Nov 12, 2022
@rithviknishad rithviknishad mentioned this pull request Nov 12, 2022
Closed
14 tasks
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@rithviknishad @aeswibon
fix issue with search input accidentally debouncing (ohcnetwork#4037)
aab055e 
* fix issue with searcch input accidentally debocuncing

* Fix SearchInput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to clear search
3 participants
@rithviknishad @nihal467 @khavinshankar