Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve applied filter badges on Users page #4039

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Improve applied filter badges on Users page #4039

merged 1 commit into from
Nov 16, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Nov 11, 2022

Fixes #4029

  • This PR makes the badges uniform on smaller screens; they are now easier to read and delete individually.
  • This PR only changes the badges on small screens (<=640px). Badges are unaffected for larger displays.

Before:
image

After:
RemarkableNurseshark

On larger displays (No change):
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team November 11, 2022 15:26
@Ashesh3 Ashesh3 requested a review from a team as a code owner November 11, 2022 15:26
@Ashesh3 Ashesh3 requested a review from bodhish November 11, 2022 15:26
@vercel
Copy link

vercel bot commented Nov 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 3:27PM (UTC)

@netlify
Copy link

netlify bot commented Nov 11, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7824335
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636e69941498e700086aedc3
😎 Deploy Preview https://deploy-preview-4039--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 594ad22 into coronasafe:develop Nov 16, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@Ashesh3 @aeswibon
Improve applied filter badges on Users page (coronasafe#4039)
5b1a723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badges are getting misaligned in user management page
3 participants
@Ashesh3 @nihal467 @khavinshankar