Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add patient note on discharged patients gives error notification #4050

Merged
merged 6 commits into from
Nov 15, 2022
Merged

Add patient note on discharged patients gives error notification #4050

merged 6 commits into from
Nov 15, 2022

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Nov 13, 2022 •
edited
Loading

@Pranshu1902 Pranshu1902 requested a review from a team November 13, 2022 09:32
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner November 13, 2022 09:32
@vercel
Copy link

vercel bot commented Nov 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 6:34AM (UTC)

@netlify
Copy link

netlify bot commented Nov 13, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 53ee663
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6371e130fe87ab00099e67d2
😎 Deploy Preview https://deploy-preview-4050--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us disable the add patient notes textbox and button when the patient is inactive.

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Nov 14, 2022 •
edited
Loading

@rithviknishad Done!
Button disabled
image

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit e7be53c into coronasafe:develop Nov 15, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@Pranshu1902 @aeswibon
Add patient note on discharged patients gives error notification (cor…
ffcfc79 
…onasafe#4050)

* debugged

* test

* resolved bug

* final

* added warning

* disabled button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add patient note shouldn't work for discharged patients
4 participants
@Pranshu1902 @nihal467 @rithviknishad @khavinshankar