Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FacilitySelect): Minor UI fix in patient popup #4064

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Nov 16, 2022

Bug Fix

Proposed Changes

  • Added Tailwind Dialog Modal
  • Fixed the Add patient popup size
  • Fixed alignment of buttons in the Add patient popup

Associated Issue

Screenshot

  • FacilitySelect Popup

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update productdocumentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team November 16, 2022 13:36
@aeswibon aeswibon requested a review from a team as a code owner November 16, 2022 13:36
@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 25caf4b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6382191d47fd840008fd760e
😎 Deploy Preview https://deploy-preview-4064--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 26, 2022 at 1:50PM (UTC)

@github-actions
Copy link

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 17, 2022
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change such that, ConfirmDialog is for operations like delete, archive, etc...
  • Use normal DialogV2 for things like Facility Selects.

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 24, 2022
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 54509c8 into coronasafe:develop Nov 30, 2022
aeswibon added a commit to aeswibon/care_fe that referenced this pull request Dec 7, 2022
* feat(Modal): added Dialog and ConfirmDialog Modal

* fix(FacilityDialog): fixed dialog size and alignment of buttons

* fix(FacilityDialog): switched to dialog for facility select
aeswibon added a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
* feat(Modal): added Dialog and ConfirmDialog Modal

* fix(FacilityDialog): fixed dialog size and alignment of buttons

* fix(FacilityDialog): switched to dialog for facility select
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create custom Modals Minor UI Fix in the add patient Pop-up at patient tab
4 participants