Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a feature take cove Image photos directly from Care #4089

Closed
wants to merge 17 commits into from
Closed

Added a feature take cove Image photos directly from Care #4089

wants to merge 17 commits into from

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Nov 21, 2022 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team November 21, 2022 05:53
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner November 21, 2022 05:53
@netlify
Copy link

netlify bot commented Nov 21, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2a7a5ec
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63ab2c8ef5e5140009f9ddea
😎 Deploy Preview https://deploy-preview-4089--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 27, 2022 at 5:36PM (UTC)

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2022
View reviewed changes
src/Components/Facility/CoverImageEditModal.tsx
{hasImage ? (
<div className="flex-1 flex m-8 rounded-lg items-center justify-center">
<img
src={imgSrc}

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Dec 1, 2022

@patelaryan7751
image

the camera is not turning on in the windows chrome browser

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751
Copy link
Contributor Author

Closing this openning a fresh and clean PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
needs review needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a feature to take pictures directly from care while setting the facility image
2 participants
@patelaryan7751 @nihal467