Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow future dates for facility triage #4094

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Don't allow future dates for facility triage #4094

merged 5 commits into from
Dec 6, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #4093
http://localhost:4000/facility/072e9364-a108-42e2-a0a5-3e70f9d90e3c/triage
The form raises an error when submitting the form with an invalid date
image

@Pranshu1902 Pranshu1902 requested a review from a team November 22, 2022 08:12
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner November 22, 2022 08:12
@netlify
Copy link

netlify bot commented Nov 22, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d9a6055
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638c34d0485a8e00081949c6
😎 Deploy Preview https://deploy-preview-4094--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 5:50AM (UTC)

@nihal467
Copy link
Member

test approved

khavinshankar
khavinshankar requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902

  • can you change all the mui components in this form to our custom components
  • and also add constraints in the DateInput component to disable future dates (something like maxDate)

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Nov 25, 2022 •
edited
Loading

@khavinshankar Done!
Disabled future dates
image

Removed MUI buttons
image

@nihal467
Copy link
Member

LGTM

khavinshankar
khavinshankar requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902 also change the date picker too, not only the buttons, we already have custom date pickers

@nihal467
Copy link
Member

nihal467 commented Dec 4, 2022

@Pranshu1902 @khavinshankar is it good for testing

@Pranshu1902
Copy link
Contributor Author

Updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Dec 5, 2022

LGTM

@khavinshankar
Copy link
Member

khavinshankar commented Dec 6, 2022 •
edited by Pranshu1902
Loading

  • Add max and min props in DateInputV2 to set limits or constraints for date selection

@khavinshankar khavinshankar mentioned this pull request Dec 6, 2022
Closed
@khavinshankar khavinshankar merged commit e11d44b into coronasafe:develop Dec 6, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@Pranshu1902 @aeswibon
Don't allow future dates for facility triage (coronasafe#4094)
1b7d2f5 
* dont validate future dates

* removed mui and added max date contraint

* added custom date picker

* improved ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Future dates shouldn't be allowed in facility triage date
3 participants
@Pranshu1902 @nihal467 @khavinshankar