Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed auto scroll to top on Users page #4124

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Removed auto scroll to top on Users page #4124

merged 4 commits into from
Dec 6, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #4123
Removed auto scroll when clicking the Click here to show linked facilities button
image

@Pranshu1902 Pranshu1902 requested a review from a team November 27, 2022 05:33
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner November 27, 2022 05:33
@netlify
Copy link

netlify bot commented Nov 27, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e467401
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638c366a2db51400089e9f6f
😎 Deploy Preview https://deploy-preview-4124--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 5:57AM (UTC)

Ashesh3
Ashesh3 requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is still happening.

UnnaturalRingtailedlemur

@nihal467
Copy link
Member

nihal467 commented Nov 30, 2022 •
edited
Loading

@Pranshu1902 issue still persist

@nihal467
Copy link
Member

nihal467 commented Dec 4, 2022

@Pranshu1902 what is the status on this PR

@nihal467 nihal467 added the P1 breaking issue or vital feature label Dec 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Pranshu1902
Copy link
Contributor Author

@nihal467 bug resolved

@nihal467
Copy link
Member

nihal467 commented Dec 5, 2022

LGTM

@khavinshankar
Copy link
Member

@Ashesh3 can you re-review this one

Ashesh3
Ashesh3 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!

@khavinshankar khavinshankar merged commit 6dbbe8a into coronasafe:develop Dec 6, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@Pranshu1902 @aeswibon
Removed auto scroll to top on Users page (coronasafe#4124)
d6cc2a6 
* removed auto scroll to top

* refactor

* removed auto scroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-scroll is malfunctioning in User management page
4 participants
@Pranshu1902 @nihal467 @khavinshankar @Ashesh3