Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: Added an option to rotate images in preview #4130

Merged
merged 4 commits into from
Dec 8, 2022
Merged

FileUpload: Added an option to rotate images in preview #4130

merged 4 commits into from
Dec 8, 2022

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Nov 27, 2022 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team November 27, 2022 08:50
@khavinshankar khavinshankar requested a review from a team as a code owner November 27, 2022 08:50
@vercel
Copy link

vercel bot commented Nov 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 7:46AM (UTC)

@netlify
Copy link

netlify bot commented Nov 27, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 734fbe1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63904484b74fc00009c39a6f
😎 Deploy Preview https://deploy-preview-4130--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 27, 2022
@khavinshankar
Copy link
Member Author

image

@nihal467
Copy link
Member

@khavinshankar the rotate left and rotate right button functions are interchanged

@github-actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 30, 2022
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 1, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

Test approved

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gigincg gigincg merged commit 039de00 into develop Dec 8, 2022
@gigincg gigincg deleted the feat#4129 branch December 8, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature : image in consultation file upload should be able to rotate
3 participants
@khavinshankar @nihal467 @gigincg