Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the Ui uniform by changing the phone number field bg color to white #4144

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Made the Ui uniform by changing the phone number field bg color to white #4144

merged 2 commits into from
Dec 7, 2022

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team November 28, 2022 18:26
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner November 28, 2022 18:26
@vercel
Copy link

vercel bot commented Nov 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 8:18PM (UTC)

@netlify
Copy link

netlify bot commented Nov 28, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 67df1f8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638d00376551da00083a375f
😎 Deploy Preview https://deploy-preview-4144--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Dec 1, 2022

@patelaryan7751 was it discussed in EOD and I can see a comment by @rithviknishad

@nihal467 nihal467 added question Further information is requested work-in-progress and removed needs testing labels Dec 1, 2022
@patelaryan7751
Copy link
Contributor Author

Design For Fields discussed in EOD @nihal467
image

@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751 patelaryan7751 added needs testing and removed question Further information is requested work-in-progress labels Dec 4, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 5, 2022

@patelaryan7751 can you change the existing Screenshot on this PR and replace it with new one

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 it is the same i have only done some code refactoring it's the whole same thing.

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

@patelaryan7751
image

the text-box input area colour in the schema is grey-100, was it not intentionally changed? or my understanding is wrong?

@nihal467 nihal467 added the question Further information is requested label Dec 6, 2022
@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 according to the discussion in EOD Gigin told to keep the input box white so i have changed it from grey to white . Gigin told to keep small input box white and textarea fields grey in color

@patelaryan7751
Copy link
Contributor Author

Design For Fields discussed in EOD @nihal467 image

@nihal467 this is the image he told to refer while having color in input and textarea boxes

@nihal467
Copy link
Member

nihal467 commented Dec 7, 2022

test approved

@nihal467 nihal467 removed question Further information is requested needs testing labels Dec 7, 2022
@nihal467 nihal467 added the tested label Dec 7, 2022
@khavinshankar khavinshankar merged commit 1e413e2 into coronasafe:develop Dec 7, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@patelaryan7751 @aeswibon
Made the Ui uniform by changing the phone number field bg color to wh…
939c304 
…ite (coronasafe#4144)

* Made the Ui uniform by changing the phone number field bg color to white

* Refactored the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Patients page the Ui is a bit less uniform some fields have different background colour then the rest.
4 participants
@patelaryan7751 @nihal467 @rithviknishad @khavinshankar