Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the adding cover image feature visible in mobile devices when there is no cover image #4149

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Made the adding cover image feature visible in mobile devices when there is no cover image #4149

merged 2 commits into from
Dec 8, 2022

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team November 29, 2022 12:59
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner November 29, 2022 12:59
@netlify
Copy link

netlify bot commented Nov 29, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c32add8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638cf7782db5140008a9a72e
😎 Deploy Preview https://deploy-preview-4149--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 7:40PM (UTC)

developedBySJ
developedBySJ suggested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Desktop devices, User can see the upload button on hover but for mobile, It is hard to find it
Show the upload button by default for mobile devices

src/Components/Facility/FacilityHome.tsx Show resolved Hide resolved
@nihal467
Copy link
Member

@patelaryan7751 i can see a comment by @developedBySJ once its complete, mark it for testing

@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

LGTM

@gigincg gigincg merged commit b8f4e57 into coronasafe:develop Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar requested changes

@developedBySJ developedBySJ developedBySJ requested changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
changes required tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When there is no cover image of a facility you cannnot add the cover image in mobile devices
5 participants
@patelaryan7751 @nihal467 @khavinshankar @developedBySJ @gigincg