Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Waveform preview to asset configure page #4197

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Added Waveform preview to asset configure page #4197

merged 4 commits into from
Dec 7, 2022

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Dec 3, 2022 •
edited
Loading

Proposed Changes

After:
image

Before:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team December 3, 2022 09:48
@shivankacker shivankacker requested a review from a team as a code owner December 3, 2022 09:48
@vercel
Copy link

vercel bot commented Dec 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 9:15AM (UTC)

@netlify
Copy link

netlify bot commented Dec 3, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a97cab8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638f07de1d84c60009a1c46d
😎 Deploy Preview https://deploy-preview-4197--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

LGTM

@khavinshankar khavinshankar merged commit bba0ce9 into develop Dec 7, 2022
@khavinshankar khavinshankar deleted the waveform-configure branch December 7, 2022 06:14
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@shivankacker @aeswibon
Added Waveform preview to asset configure page (ohcnetwork#4197)
b17f7b9 
* Added Waveform Preview to asset configure page

* reduced form width

* made dynamic loading

* changed UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Waveform preview in asset configuration page
3 participants
@shivankacker @nihal467 @khavinshankar