Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative timestamps for Patient Details #4198

Merged
merged 5 commits into from
Dec 7, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 3, 2022

Fixes #4022

https://care.coronasafe.in/facility/c2d37a3e-3b82-4a12-881f-5faca5a44134/patient/4611a8b6-4aa8-497b-ac21-1c0fdc8ba971

  • Extract the user mention with time to a separate component RelativeDateUserMention
  • Add Tooltip to display the full date and time on hover.

image
image
image
image
image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team December 3, 2022 11:36
@Ashesh3 Ashesh3 requested a review from a team as a code owner December 3, 2022 11:36
@Ashesh3 Ashesh3 requested a review from gigincg December 3, 2022 11:36
@vercel
Copy link

vercel bot commented Dec 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:53AM (UTC)

@netlify
Copy link

netlify bot commented Dec 3, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 90ec42c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639070012f0acf0009557dcb
😎 Deploy Preview https://deploy-preview-4198--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit dc4229b
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63906f4b4553160008982976

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Dec 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 389 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@Ashesh3 Ashesh3 removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict labels Dec 7, 2022
@khavinshankar khavinshankar merged commit f034ab2 into coronasafe:develop Dec 7, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
* Relative timestamps for Patient Details

* Switch to CareIcon

* CareIcon import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative timestamps for Consultation history and Sample Test cards
3 participants