Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patient): re-admission is using existing consultation #4215

Merged
merged 2 commits into from
Dec 8, 2022
Merged

fix(patient): re-admission is using existing consultation #4215

merged 2 commits into from
Dec 8, 2022

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Dec 4, 2022

Bug Fix

Proposed Changes

  • Added No consultation filed for re-admitted patient having no new consultation
  • Added consultation button for the above patient types

Associated Issue

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update productdocumentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team December 4, 2022 12:51
@aeswibon aeswibon requested a review from a team as a code owner December 4, 2022 12:51
@netlify
Copy link

netlify bot commented Dec 4, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5ead23f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63918bd33882bd0008b23dc2
😎 Deploy Preview https://deploy-preview-4215--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 7:02AM (UTC)

@aeswibon aeswibon added needs testing P1 breaking issue or vital feature labels Dec 4, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 5, 2022

@cp-Coder
image

the readmitted patient consultation history is not available

@khavinshankar khavinshankar added the question Further information is requested label Dec 6, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 7, 2022

@cp-Coder what is the status on p1 issues

@aeswibon aeswibon added needs testing and removed test failed question Further information is requested labels Dec 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Dec 8, 2022

test approved

@khavinshankar khavinshankar merged commit f0e7b7b into coronasafe:develop Dec 8, 2022
aeswibon added a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@aeswibon
fix(patient): re-admission is using existing consultation (coronasafe…
99c3ccc 
…#4215)

* fix(patient): added no consultation badge for re-admitted patient having no new consultation

* fix(patient): added re-admitted patient consultation history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readmission is using existing consultation
3 participants
@aeswibon @nihal467 @khavinshankar