-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds config.json
, useConfig
hook and move dashboard_url
from env to config
#4223
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
1 similar comment
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Proposed Changes
dashboard_url
is now set fromconfig.json
instead ofenv
. This change will work in staging, however for production,REACT_APP_CONFIG
env needs to be configured.Notes
Set the URL to the
config.json
file in environment (defaults to:"/config.json"
)An example
config.json
is specified in/public/config.json
:Whenever adding/removing configs, do update the
IConfig
interface in/src/Common/hooks/useConfig.ts
.Use the configurations inside the app as shown:
The
config.json
is cached in local storage (key:"config"
).@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist