Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (HospitalList): textarea of notify facility modal #4227

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

naman114
Copy link
Contributor

@naman114 naman114 commented Dec 5, 2022

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@naman114 naman114 requested a review from a team December 5, 2022 20:15
@naman114 naman114 requested a review from a team as a code owner December 5, 2022 20:15
@naman114 naman114 requested a review from bodhish December 5, 2022 20:15
@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 11:06AM (UTC)

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b62ffae
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638f21dd40d3d4000874196e
😎 Deploy Preview https://deploy-preview-4227--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@gigincg gigincg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, move any functions that are not used in the HospitalList component to the FacilityCard

And move FacilityCard to a separate Component File

@naman114 naman114 requested a review from gigincg December 6, 2022 11:05
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

LGTM

import { useState } from "react";
import { useDispatch } from "react-redux";
import { navigate } from "raviger";
import { TextField, Modal } from "@material-ui/core";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naman114 can you refactor it to use custom components rather that mui

@nihal467
Copy link
Member

nihal467 commented Dec 7, 2022

@naman114 what is the status of the PR

@gigincg gigincg merged commit 9e1ef6b into ohcnetwork:develop Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility Notify Textarea Not Accepting Input
4 participants