Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(cypress): Patient spec test #4236

Closed
wants to merge 15 commits into from
Closed

Fix(cypress): Patient spec test #4236

wants to merge 15 commits into from

Conversation

rabilrbl
Copy link
Contributor

@rabilrbl rabilrbl commented Dec 6, 2022 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@rabilrbl
Fix(cypress): Patient CRUD
ed0f6ba 
- Fix creation
- Update
- Add test for Doctor's notes
@rabilrbl rabilrbl requested a review from a team December 6, 2022 13:31
@rabilrbl rabilrbl requested a review from a team as a code owner December 6, 2022 13:31
@rabilrbl rabilrbl requested a review from bodhish December 6, 2022 13:31
@vercel
Copy link

vercel bot commented Dec 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 5:11AM (UTC)

@netlify
Copy link

netlify bot commented Dec 6, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit eea5485
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/640abb8078c8a2000871619e
😎 Deploy Preview https://deploy-preview-4236--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rabilrbl rabilrbl changed the title Fix(cypress): Patient CRUD Fix(cypress): Patient spec test Dec 6, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 6, 2022
@GokulramGHV GokulramGHV added needs testing and removed work-in-progress cypress failed pull request with cypress test failure labels Dec 9, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 12, 2022
@github-actions
Copy link

👋 Hi, @rabilrbl,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@GokulramGHV GokulramGHV removed the merge conflict pull requests with merge conflict label Dec 13, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 13, 2022
@nihal467
Copy link
Member

@khavinshankar can you check this PR

@nihal467
Copy link
Member

@rabilrbl check the cypress

@nihal467
Copy link
Member

@rabilrbl what is the status on this PR

@nihal467
Copy link
Member

@rabilrbl check the cypress and once it is fully ready for testing, mark it for testing

@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 2 Code Smells

No Coverage information No Coverage information
18.9% 18.9% Duplication

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

👋 Hi, @rabilrbl,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 6, 2023
@nihal467
Copy link
Member

nihal467 commented Jan 9, 2023 •
edited
Loading

@rabilrbl what is the status of the PR

@rabilrbl
Copy link
Contributor Author

rabilrbl commented Jan 9, 2023

The patient crud from multiple user type is failing.

The backend docker image doesn't have these new user credentials.

cc: @GokulramGHV

@rabilrbl
Copy link
Contributor Author

rabilrbl commented Feb 6, 2023

@GokulramGHV Any updates?

@nihal467
Copy link
Member

nihal467 commented Feb 6, 2023

@GokulramGHV @rabilrbl get this PR ready for testing ASAP

@nihal467 nihal467 added the stale label Feb 6, 2023
@GokulramGHV GokulramGHV mentioned this pull request Feb 6, 2023
Merged
3 tasks
@github-actions github-actions bot removed the stale label Feb 7, 2023
@nihal467
Copy link
Member

@GokulramGHV what is the status on this PR

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Mar 4, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

👋 Hi, @rabilrbl,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Mar 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar
Copy link
Member

@GokulramGHV can you check if this pr is still relevant now?

@github-actions
Copy link

👋 Hi, @rabilrbl,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 19, 2023
@nihal467
Copy link
Member

nihal467 commented Aug 2, 2023

@rabilrbl @SahilSingh177 We are re-writing the whole patient test in the POM approach, so closing this PR

@nihal467 nihal467 closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict work-in-progress
Projects
None yet
Milestone
No milestone
4 participants
@rabilrbl @nihal467 @khavinshankar @GokulramGHV