-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move export asset button beside asset name and improve import/export icons and fix button border control #4244
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LGTM, @rithviknishad marking it team discussion required, to get a final opinion from the team |
@rithviknishad will you be working on the changes, from removing the button and adding a download icon in the same row as the asset name |
@nihal467 the following changes were made (screenshots updated in PR's first comment):
Ready for testing. |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
LGTM but @rithviknishad work on the merge conflict |
❌ Deploy Preview for care-net failed.
|
…h what was in `develop`
@nihal467 i've fixed the merge conflict |
the page is getting extended to the right side, due to the tooltip, in responsive view |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
LGTM |
Proposed Changes
ButtonV2
got a new controllableborder
prop for finer design control.Move asset export beside the asset name and added a tooltip.
Improved the import and export icon in asset list page
ButtonV2
can now beghost
withoutborder
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist