Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added middleware update feature #4260

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Added middleware update feature #4260

merged 1 commit into from
Dec 9, 2022

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Dec 8, 2022 •
edited
Loading

Feature Request

Proposed Changes

  • Added middleware address update route and page

Associated Issue

Associated PRs

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update productdocumentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team December 8, 2022 16:26
@aeswibon aeswibon requested a review from a team as a code owner December 8, 2022 16:26
@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a5e5f47
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639210496432a0000824016e
😎 Deploy Preview https://deploy-preview-4260--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 4:28PM (UTC)

@aeswibon aeswibon added the waiting for related PR a co-related detail PR is under construction label Dec 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Dec 9, 2022

test approved

@nihal467 nihal467 added tested and removed waiting for related PR a co-related detail PR is under construction labels Dec 9, 2022
@khavinshankar khavinshankar merged commit ccbf77a into coronasafe:develop Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facility Config Page
4 participants
@aeswibon @nihal467 @rithviknishad @khavinshankar