Handle situation when coverimg fails to upload also added hints for uploading coverimage #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ploading coverimage
…ploading coverimage
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <> | ||
| <div className="flex-1 flex m-8 rounded-lg items-center justify-center"> | ||
| <img | ||
| src={imgSrc} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML
|
|
|
LGTM |
Comment on lines
139
to
146
| <p className="text-gray-700 font-medium text-center"> | ||
| Max size for image uploaded should be 1mb. | ||
| <br /> | ||
| Allowed formats are jpg,png,jpeg. | ||
| <br /> | ||
| Recommended aspect ratio for facility cover photo is 1:1. | ||
| </p> | ||
| </> |
There was a problem hiding this comment.
this part seems to be repeating, why not refactor it
There was a problem hiding this comment.
yeah refactored
|
@patelaryan7751 what is the status on the PR |
|
Kudos, SonarCloud Quality Gate passed!
|
khavinshankar
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist