Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone Number filter malfunction resolved and minor UI fixes #4268

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Phone Number filter malfunction resolved and minor UI fixes #4268

merged 2 commits into from
Dec 15, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #4267

@Pranshu1902 Pranshu1902 requested a review from a team December 10, 2022 10:37
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner December 10, 2022 10:37
@netlify
Copy link

netlify bot commented Dec 10, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7dbc182
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639ae65a70a4480008023d3e
😎 Deploy Preview https://deploy-preview-4268--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 9:19AM (UTC)

@nihal467
Copy link
Member

LGTM

@khavinshankar
Copy link
Member

@Pranshu1902 can you merge this with the develop branch and after merging if cypress fails, please do resolve that

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Dec 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Pranshu1902
Copy link
Contributor Author

@khavinshankar done!

@Pranshu1902 Pranshu1902 removed the cypress failed pull request with cypress test failure label Dec 15, 2022
@khavinshankar khavinshankar merged commit 0f09195 into coronasafe:develop Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phone number filter malfunction and UI fixes
3 participants
@Pranshu1902 @nihal467 @khavinshankar