Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added user details and time of archive in the more details modal #4281

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Added user details and time of archive in the more details modal #4281

merged 4 commits into from
Dec 15, 2022

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team December 12, 2022 10:51
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner December 12, 2022 10:51
@vercel
Copy link

vercel bot commented Dec 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 11:20AM (UTC)

@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5c21b64
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639b02b749b6f2000954f4d4
😎 Deploy Preview https://deploy-preview-4281--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@patelaryan7751 can you merge this with the develop branch and after merging if cypress fails, please do resolve that

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Dec 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.2% 11.2% Duplication

@khavinshankar khavinshankar merged commit 1f9098a into coronasafe:develop Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the name of user and time details of Archived File to the Modal in File Upload Modal
3 participants
@patelaryan7751 @nihal467 @khavinshankar