Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location selection to asset import and fix reload bug #4284

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Add location selection to asset import and fix reload bug #4284

merged 1 commit into from
Dec 12, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 12, 2022

  • Add location select to asset import, which allows the asset to be imported to a user specified location inside a Facility. This allows assets to be imported across facilities and deployments.
  • Fixed a bug where the import button would trigger a full page reload, breaking the import modal.

When there are no locations in the Facility

image

With location selection

image

After importing

image

@Ashesh3 Ashesh3 requested a review from a team December 12, 2022 14:39
@Ashesh3 Ashesh3 requested a review from a team as a code owner December 12, 2022 14:39
@vercel
Copy link

vercel bot commented Dec 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 2:40PM (UTC)

@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 65856d8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63973d0e9977310008ea239b
😎 Deploy Preview https://deploy-preview-4284--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@gigincg gigincg merged commit 87faa53 into coronasafe:develop Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ashesh3 @gigincg