Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate implementation of useMergeState hook #4287

Merged
merged 1 commit into from
Dec 20, 2022
Merged

De-duplicate implementation of useMergeState hook #4287

merged 1 commit into from
Dec 20, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 13, 2022 •
edited
Loading

Proposed Changes

(Plucked out from #3996 to make it easier to review)

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team December 13, 2022 04:35
@rithviknishad rithviknishad requested a review from a team as a code owner December 13, 2022 04:35
@vercel
Copy link

vercel bot commented Dec 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 4:37AM (UTC)

@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fbafca2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63980131dc146c0008ed82a3
😎 Deploy Preview https://deploy-preview-4287--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.7% 16.7% Duplication

@nihal467
Copy link
Member

the filters across the platform LGTM

@khavinshankar khavinshankar merged commit 2ec26fb into coronasafe:develop Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate re-definitions of useMergeState hook.
3 participants
@rithviknishad @nihal467 @khavinshankar