Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete asset button #4304

Merged
merged 11 commits into from
Dec 28, 2022
Merged

Delete asset button #4304

merged 11 commits into from
Dec 28, 2022

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Dec 13, 2022 •
edited
Loading

Proposed Changes

image
(Note - Export button will be moved later on)

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@skks1212 skks1212 requested a review from a team December 13, 2022 18:15
@skks1212 skks1212 requested a review from a team as a code owner December 13, 2022 18:15
@vercel
Copy link

vercel bot commented Dec 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 27, 2022 at 2:53PM (UTC)

@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4757b52
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63ab0646b0a6650009fb5bd6
😎 Deploy Preview https://deploy-preview-4304--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 0f1d6aa
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/639b2481ddfc120008069290

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Dec 13, 2022
@skks1212 skks1212 added needs testing waiting for backend P1 breaking issue or vital feature and removed work-in-progress Deploy-Failed Deplyment is not showing preview labels Dec 14, 2022
@github-actions
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 15, 2022
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Dec 15, 2022
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Dec 15, 2022
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Dec 15, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 19, 2022
@nihal467
Copy link
Member

@skks1212 https://deploy-preview-4304--care-net.netlify.app/facility/fdad4400-bd11-49dd-9da1-5be0e79fa14e/assets/4ba8c734-a30c-42cc-93c6-b5e5b3028c28

image

the responsiveness is still not fixed, and check the cypress too

@nihal467 nihal467 mentioned this pull request Dec 21, 2022
Closed
@nihal467
Copy link
Member

nihal467 commented Dec 21, 2022 •
edited
Loading

@khavinshankar @gigincg conditionally approving this PR, as it serves the functionality, and the responsiveness issue will be followed up with #4379

@skks1212 check the cypress failed

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 22, 2022
@github-actions
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@skks1212 skks1212 removed the merge conflict pull requests with merge conflict label Dec 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Dec 27, 2022
@khavinshankar khavinshankar mentioned this pull request Dec 28, 2022
Closed
@khavinshankar khavinshankar merged commit 6a86071 into develop Dec 28, 2022
@rithviknishad rithviknishad deleted the delete-asset-button branch July 26, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add delete button in asset detail page
4 participants
@skks1212 @nihal467 @khavinshankar @rithviknishad