Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Import and Export + Add create asset button on asset list page + Fix patients page padding #4310

Merged
merged 26 commits into from
Dec 16, 2022
Merged

Generalize Import and Export + Add create asset button on asset list page + Fix patients page padding #4310

merged 26 commits into from
Dec 16, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 14, 2022 •
edited
Loading

Proposed Changes

Generalization of Import / Export

  • Facilities
  • Patients
  • Assets: Import and Export for District and State Admins
  • Sample Test
  • Shifting (for both list and board view)
  • Resource (for both list and board view)
  • External Results

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Create assets directly from the Asset list page (@Ashesh3)

image

Fixes inconsistent padding present in patients page

image

So many variations of Import and Export buttons now became just one variation

image

image

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad added P1 breaking issue or vital feature work-in-progress labels Dec 14, 2022
@vercel
Copy link

vercel bot commented Dec 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 1:57PM (UTC)

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 281476a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639c78f53a56ed0008ff0205
😎 Deploy Preview https://deploy-preview-4310--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ashesh3 Ashesh3 changed the title Generalize Import and Export + (@ashesh replace this with your changes) Generalize Import and Export + Add create asset button on asset list page Dec 14, 2022
@rithviknishad rithviknishad changed the title Generalize Import and Export + Add create asset button on asset list page Generalize Import and Export + Add create asset button on asset list page + Fix patients page padding Dec 14, 2022
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Dec 15, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 15, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Dec 15, 2022
@rithviknishad rithviknishad mentioned this pull request Dec 15, 2022
Closed
@nihal467
Copy link
Member

@rithviknishad PR LGTM, marking it for Team discussion required for final UI Approval.

@rithviknishad check the cypress deplyment

@rithviknishad
Copy link
Member Author

@nihal467 I've updated the cypress test for external results

@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Dec 16, 2022
@khavinshankar
Copy link
Member

@nihal467 this pr was already discussed in yesterday's EOD I guess, wasn't it already approved @rithviknishad?

@rithviknishad
Copy link
Member Author

rithviknishad commented Dec 16, 2022 •
edited
Loading

@khavinshankar yes, kindly review it :)

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 31 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Dec 16, 2022
@khavinshankar khavinshankar merged commit eb21d56 into develop Dec 16, 2022
@rithviknishad rithviknishad deleted the dropdown-for-exports branch July 26, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees

@Ashesh3 Ashesh3

@rithviknishad rithviknishad

Labels
Major Code Change This Tag represent PR, which will be causing major Code change in the platform P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
4 participants
@rithviknishad @nihal467 @khavinshankar @Ashesh3