Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Linked Facility button added on Users page #4324

Merged
merged 17 commits into from
Dec 28, 2022
Merged

Hide Linked Facility button added on Users page #4324

merged 17 commits into from
Dec 28, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #4323
Added button to hide linked facilities
image

@Pranshu1902 Pranshu1902 requested a review from a team December 16, 2022 14:36
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner December 16, 2022 14:36
@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8f51f3f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a5dbf06fe6150008662b8b
😎 Deploy Preview https://deploy-preview-4324--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 4:51PM (UTC)

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@Pranshu1902 the functionality works well, but can you polish the UI!
my suggestion would be, to have an eye icon that can be toggled, and also have a max width for the facilities and make it scrollable
feel free to bring this up in an EOD call

cc: @nihal467

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Dec 21, 2022 •
edited
Loading

@nihal467 @khavinshankar
Updated view:
image

image

@khavinshankar
Copy link
Member

@nihal467 can you retest this pr

@nihal467
Copy link
Member

LGTM

@khavinshankar
Copy link
Member

@Pranshu1902 clear the failing cypress tests

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Dec 22, 2022
@Pranshu1902
cypress
640e79d
@Pranshu1902
Revert "cypress"
be0a146 
This reverts commit 4f36952bfdee04cd8d3e81c3fcb9e75115261d52.
@Pranshu1902
fixed cypress
3dfa1ca
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Pranshu1902 Pranshu1902 removed the cypress failed pull request with cypress test failure label Dec 23, 2022
@Pranshu1902
Copy link
Contributor Author

@khavinshankar cypress error resolved!

@khavinshankar khavinshankar merged commit 371b279 into coronasafe:develop Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide Linked Facilities option on Users page
3 participants
@Pranshu1902 @nihal467 @khavinshankar