Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable past dates for warranty expiry date on create assets page #4327

Merged
merged 13 commits into from
Dec 22, 2022
Merged

Disable past dates for warranty expiry date on create assets page #4327

merged 13 commits into from
Dec 22, 2022

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Dec 17, 2022 •
edited
Loading

Fixes #4326

@Pranshu1902 Pranshu1902 requested a review from a team December 17, 2022 06:11
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner December 17, 2022 06:11
@vercel
Copy link

vercel bot commented Dec 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 9:14AM (UTC)

@netlify
Copy link

netlify bot commented Dec 17, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0d446ec
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a17c7f7a992a00088c1127
😎 Deploy Preview https://deploy-preview-4327--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@Pranshu1902
image

  • today is the 19th, and the date is greyed out in the calender, which shouldn't be
  • unable to submit the form, there coming up a error

@Pranshu1902
Copy link
Contributor Author

@nihal467 Error resolved!

@nihal467
Copy link
Member

@Pranshu1902
image

https://deploy-preview-4327--care-net.netlify.app/facility/7ab27974-32c8-4e36-bdf9-dbf102524718/assets/ab12b691-5769-4e6f-a6d1-d6d2028dca07/update

when we open a existing asset for updating, the screen goes white

@Pranshu1902
Copy link
Contributor Author

@nihal467 All bugs resolved!

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit c611a97 into coronasafe:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow past dates for Waranty Expiry on Asset Creating form
3 participants
@Pranshu1902 @nihal467 @khavinshankar