Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end>start constraint to DateRangeInputV2 #4329

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Add end>start constraint to DateRangeInputV2 #4329

merged 3 commits into from
Dec 21, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 17, 2022 •
edited
Loading

Fixes #3983

QuirkyAmericanbulldog

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team December 17, 2022 07:58
@Ashesh3 Ashesh3 requested a review from a team as a code owner December 17, 2022 07:58
@Ashesh3 Ashesh3 requested a review from bodhish December 17, 2022 07:58
@vercel
Copy link

vercel bot commented Dec 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 5:16AM (UTC)

@netlify
Copy link

netlify bot commented Dec 17, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7a0c0be
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a29648c3b7910008618015
😎 Deploy Preview https://deploy-preview-4329--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad
Copy link
Member

rithviknishad commented Dec 17, 2022 •
edited
Loading

@Ashesh3 the swapping feels weird, one might feel that it didn't select what they clicked.

Just a suggestion, how about disabling users from selecting a date that is beyond constraint?
For example: If I select start: Dec 1, in the end-picker, dates on or before Dec 1 shall be disabled.

@rithviknishad
Copy link
Member

I guess we could achieve that by manipulating the min and max prop of DateInput during onChange?

@nihal467
Copy link
Member

LGTM

@khavinshankar
Copy link
Member

@Ashesh3 can you checkout the cypress fails, likely merging the develop branch should fix it

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Dec 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ashesh3 Ashesh3 removed the cypress failed pull request with cypress test failure label Dec 21, 2022
@khavinshankar khavinshankar merged commit 0f8407f into ohcnetwork:develop Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateRangePickerV2 should not allow selecting end date that's before start date.
4 participants
@Ashesh3 @rithviknishad @nihal467 @khavinshankar