Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (Advanced Filters): made all filter sidebars collapse on clearing filters #4337

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Fix (Advanced Filters): made all filter sidebars collapse on clearing filters #4337

merged 4 commits into from
Dec 22, 2022

Conversation

naman114
Copy link
Contributor

@naman114 naman114 commented Dec 17, 2022 •
edited
Loading

Proposed Changes

2022-12-22_01-20-21.mp4

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@naman114 naman114 requested a review from a team December 17, 2022 18:01
@naman114 naman114 requested a review from a team as a code owner December 17, 2022 18:01
@vercel
Copy link

vercel bot commented Dec 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 7:42PM (UTC)

@netlify
Copy link

netlify bot commented Dec 17, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ae8432a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a3613bb65fcd000896e6e0
😎 Deploy Preview https://deploy-preview-4337--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 20, 2022
@github-actions
Copy link

👋 Hi, @naman114,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@naman114 once the merge conflict is cleared, mark it for testing

@naman114 naman114 added needs testing and removed merge conflict pull requests with merge conflict labels Dec 20, 2022
@naman114
Copy link
Contributor Author

@nihal467 the merge conflict has been resolved

@nihal467
Copy link
Member

@naman114 iam marking it as team discussion required, as after clear filter, the sidebar is not collapsing, and the behaviour doesn't feel good in my view, will be discussion in the call

@naman114 naman114 changed the title Fix (FacilityFilter): sidebar collapses on clearing facility advanced filters Fix (Advanced Filters): made all filter sidebars collapse on clearing filters Dec 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.7% 7.7% Duplication

@naman114
Copy link
Contributor Author

I have made all the Advanced Filters sidebars collapse on clearing the filters. The video showing the same is updated in the PR description

@nihal467

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 0333752 into coronasafe:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearing Advanced Filters For Facilities Collapses the Sidebar
3 participants
@naman114 @nihal467 @khavinshankar