Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pagination comp. + fix ButtonV2 + adj. vertical-align of CareIcons + Generalize Submit and Cancel buttons #4358

Merged
merged 26 commits into from
Dec 22, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 19, 2022

Proposed Changes

Note

From now on we need not adjust the alignment of the icon inside button manually using pt-* / pb-* / mt-* / mb-* classes.

<ButtonV2> {/* already applies "inline-flex items-center gap-2" */}
  <CareIcon className="care-l-check text-lg" />
  <span>Verify</span>
</ButtonV2>

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

image

image

image

image

image

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 22, 2022 at 1:50PM (UTC)

@netlify
Copy link

netlify bot commented Dec 19, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e8aa6a9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a460259ebcbd0008646873
😎 Deploy Preview https://deploy-preview-4358--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad changed the title Upgrade pagination component + fix disappeard classes of ButtonV2 that caused alignment issue across platform Upgrade pagination component + fix disappeard classes of ButtonV2 + adjust baseline vertical alignment of CareIcons Dec 19, 2022
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ashesh3
Copy link
Member

Ashesh3 commented Dec 19, 2022

@rithviknishad The Cypress tests might need to be updated too.

image

@rithviknishad
Copy link
Member Author

@Ashesh3 yea on it. just finished, pushing it

@rithviknishad rithviknishad changed the title Upgrade pagination component + fix disappeard classes of ButtonV2 + adjust baseline vertical alignment of CareIcons Upgrade Pagination comp. + fix ButtonV2 + adj. vertical-align of CareIcons + Generalize Submit and Cancel buttons Dec 21, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 22, 2022
@nihal467
Copy link
Member

@rithviknishad
image

make the proper spacing between the buttons

@nihal467
Copy link
Member

@rithviknishad
image

keep the add present towards the right side, as of the existing staging

@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 22, 2022
@khavinshankar
Copy link
Member

@rithviknishad can you checkout the merge conflict

@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 48 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Dec 22, 2022
@khavinshankar khavinshankar merged commit 0ebc4e7 into coronasafe:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Code Change This Tag represent PR, which will be causing major Code change in the platform redesign tested
Projects
None yet
4 participants