-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Pagination
comp. + fix ButtonV2
+ adj. vertical-align of CareIcons
+ Generalize Submit
and Cancel
buttons
#4358
Upgrade Pagination
comp. + fix ButtonV2
+ adj. vertical-align of CareIcons
+ Generalize Submit
and Cancel
buttons
#4358
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
CareIcons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rithviknishad The Cypress tests might need to be updated too. |
@Ashesh3 yea on it. just finished, pushing it |
CareIcons
Pagination
comp. + fix ButtonV2
+ adj. vertical-align of CareIcons
+ Generalize Submit
and Cancel
buttons
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
make the proper spacing between the buttons |
keep the add present towards the right side, as of the existing staging |
LGTM |
@rithviknishad can you checkout the merge conflict |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Kudos, SonarCloud Quality Gate passed!
|
Proposed Changes
<<<
,<
,>>>
,>
texts in pagination component. #4350ButtonV2
caused byButton
class getting deleted from the codebase.CareIcons
for the angles of the pagination componentButtonV2
for navigation buttons of the pagination componenttext-*
classes to size icons instead ofh-*
.care-svg-icon__baseline
's vertical alignment to -0.175emCheckCircleOutline
icon of material UI #4367CheckCircleOutline
and it's containing buttons toCareIcon
andButtonV2
in favour of removing material UI components.Note
From now on we need not adjust the alignment of the icon inside button manually using
pt-*
/pb-*
/mt-*
/mb-*
classes.@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist