Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(asset): Asset configuration warranty date is malfunctioning #4399

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Fix(asset): Asset configuration warranty date is malfunctioning #4399

merged 1 commit into from
Dec 24, 2022

Conversation

aeswibon
Copy link
Member

Bug Fix

Proposed Changes

  • Removed formatting of warranty date if the value is null

Associated Issue

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team December 24, 2022 10:17
@aeswibon aeswibon requested a review from a team as a code owner December 24, 2022 10:17
@aeswibon aeswibon added needs testing P1 breaking issue or vital feature urgent labels Dec 24, 2022
@vercel
Copy link

vercel bot commented Dec 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 24, 2022 at 10:19AM (UTC)

@netlify
Copy link

netlify bot commented Dec 24, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fdd62d6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a6d1a3091f70000947a99e
😎 Deploy Preview https://deploy-preview-4399--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 2ff1b49 into coronasafe:develop Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset configuration warranty date is malfunctioning
4 participants
@aeswibon @nihal467 @rithviknishad @khavinshankar