Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace existing usages of TextInputFieldV2 with TextFormField #4416

Merged
merged 3 commits into from
Jan 16, 2023
Merged

fix: Replace existing usages of TextInputFieldV2 with TextFormField #4416

merged 3 commits into from
Jan 16, 2023

Conversation

aeswibon
Copy link
Member

Bug Fix

Proposed Changes

  • Replaced InputFieldV2 and InputTextField with TextFormField
  • Modified BedSelect component

Associated Issue

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team December 25, 2022 15:30
@aeswibon aeswibon requested a review from a team as a code owner December 25, 2022 15:30
@netlify
Copy link

netlify bot commented Dec 25, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5a8e67a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63c2a803d6d4cb0008b93b0d
😎 Deploy Preview https://deploy-preview-4416--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 14, 2023 at 1:05PM (UTC)

@nihal467
Copy link
Member

LGTM

@khavinshankar
Copy link
Member

@cp-Coder can you take off the failing cypress tests, most likely merging the latest develop branch should fix it

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Dec 28, 2022
@aeswibon aeswibon removed the cypress failed pull request with cypress test failure label Jan 1, 2023
@khavinshankar
Copy link
Member

@cp-Coder checkout the failing cypress tests

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Jan 3, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@netlify
Copy link

netlify bot commented Jan 14, 2023

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 2527c69
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63c2a5f98d27f000087eac02

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jan 14, 2023
@rithviknishad rithviknishad added needs testing and removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict cypress failed pull request with cypress test failure tested labels Jan 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 15dbde0 into coronasafe:develop Jan 16, 2023
@rithviknishad rithviknishad mentioned this pull request Jan 16, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace existing usages of TextInputFieldV2 with TextFormField
4 participants
@aeswibon @nihal467 @khavinshankar @rithviknishad