Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable picking future dates in consultation form's admission and symptoms onset date fields #4424

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Disable picking future dates in consultation form's admission and symptoms onset date fields #4424

merged 6 commits into from
Jan 5, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team December 26, 2022 03:33
@rithviknishad rithviknishad requested a review from a team as a code owner December 26, 2022 03:33
@netlify
Copy link

netlify bot commented Dec 26, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1cccb07
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b5a702da9e5a0009216e70
😎 Deploy Preview https://deploy-preview-4424--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 4, 2023 at 4:22PM (UTC)

@nihal467
Copy link
Member

@rithviknishad
image

unable to select today, date is the admission

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 4, 2023
@rithviknishad
Copy link
Member Author

My bad, this went unnoticed. Will fix now

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
23.5% 23.5% Duplication

@nihal467
Copy link
Member

nihal467 commented Jan 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 3c1dcd1 into coronasafe:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consultation admission date and onset symptoms date is allowing future dates
3 participants
@rithviknishad @nihal467 @khavinshankar