Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve facility filter for patients listing #4427

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix: Improve facility filter for patients listing #4427

merged 1 commit into from
Jan 5, 2023

Conversation

aeswibon
Copy link
Member

Bug Fix

Proposed Changes

  • Changed url /facility/<facility-id>/patients to /patients?facility=<facility-id>

Associated Issue

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team December 26, 2022 14:33
@aeswibon aeswibon requested a review from a team as a code owner December 26, 2022 14:33
@vercel
Copy link

vercel bot commented Dec 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 1, 2023 at 0:42AM (UTC)

@netlify
Copy link

netlify bot commented Dec 26, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8641d47
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b17f46ad543b0008269752
😎 Deploy Preview https://deploy-preview-4427--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

patient filters LGTM

@khavinshankar
Copy link
Member

@cp-Coder can you take off the failing cypress tests, most likely merging the latest develop branch should fix it

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Dec 28, 2022
@aeswibon aeswibon removed the cypress failed pull request with cypress test failure label Jan 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar
Copy link
Member

@cp-Coder checkout the failing cypress tests

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Jan 3, 2023
@khavinshankar khavinshankar merged commit 97360b6 into coronasafe:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve facility filter for patients listing
3 participants
@aeswibon @nihal467 @khavinshankar