Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Sign out button #4444

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 30, 2022

Fixes #4443

  1. Added bottom padding to make it more visible
  2. Added icon to sign out option
    image
  3. Show the sign out option in collapsed menu
    image
  4. Added Sign out option to profile page:
    image

@coronasafe/care-fe-code-reviewers @coronasafe/care-fe-code-reviewers

@Ashesh3 Ashesh3 requested a review from a team December 30, 2022 11:57
@Ashesh3 Ashesh3 requested a review from a team as a code owner December 30, 2022 11:57
@netlify
Copy link

netlify bot commented Dec 30, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fe00bc3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b30797ac594a000851638e
😎 Deploy Preview https://deploy-preview-4444--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 2, 2023 at 4:37PM (UTC)

@Ashesh3
Copy link
Member Author

Ashesh3 commented Dec 30, 2022

@aparnacoronasafe Can you check this and offer your thoughts on the changed design.

@nihal467
Copy link
Member

nihal467 commented Jan 2, 2023

PR LGTM, @Ashesh3 marking it for team discussion required for final UI approval

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jan 2, 2023

@nihal467 Changes are done.

  • Made it more gray
  • Reduced the icon size in collapsed menu

image

image

@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Jan 3, 2023

LGTM

@aparnacoronasafe
Copy link
Member

@nihal467 checked placement of new sign out option in profile. Looks good to me

@khavinshankar khavinshankar merged commit c131fad into ohcnetwork:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign out- difficult to find
4 participants