Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing ascending/descending icons in patient ordering filter #4466

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix: Missing ascending/descending icons in patient ordering filter #4466

merged 1 commit into from
Jan 5, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jan 3, 2023

Bug Fix

Proposed Changes

  • Updated classname of sort icon from l-amount to l-sort-amount

Associated Issue

Screenshot

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team January 3, 2023 02:56
@aeswibon aeswibon requested a review from a team as a code owner January 3, 2023 02:56
@aeswibon aeswibon requested a review from bodhish January 3, 2023 02:56
@vercel
Copy link

vercel bot commented Jan 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 2:58AM (UTC)

@netlify
Copy link

netlify bot commented Jan 3, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3ed46a8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b3997388a8080008e28f95
😎 Deploy Preview https://deploy-preview-4466--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Jan 3, 2023

LGTM

@khavinshankar
Copy link
Member

@cp-Coder fix the failing cypress tests

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Jan 3, 2023
@khavinshankar khavinshankar merged commit ae2135b into coronasafe:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CareIcons: missing ascending/descending icons in patient ordering filter
3 participants
@aeswibon @nihal467 @khavinshankar