Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Care UI Slideover, upgrades Notifications List and Mobile Sidebar #4487

Merged
merged 8 commits into from
Jan 5, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 4, 2023

Proposed Changes

Co-authored by @skks1212 via #3996

Desktop view (notifications)

image

Mobile view (sidebar and notifications)

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team January 4, 2023 03:58
@rithviknishad rithviknishad requested a review from a team as a code owner January 4, 2023 03:58
@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e3b157e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b4f972a3befc000951aa25
😎 Deploy Preview https://deploy-preview-4487--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 4, 2023 at 3:58AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@skks1212 skks1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naman114
Copy link
Contributor

naman114 commented Jan 4, 2023

I am not able to see the back arrow even though it can be pressed @rithviknishad

AwesomeScreenshot-1_4_2023.5.59.55PM.mp4

@rithviknishad
Copy link
Member Author

@naman114 the video recording you have is #3996 which uses unicons, and it has been removed from care. This PR is #4487 and uses Care Icons.

@nihal467
Copy link
Member

nihal467 commented Jan 5, 2023

LGTM, marking it for "Team discussion required" for final UI approval

@nihal467
Copy link
Member

nihal467 commented Jan 5, 2023

@khavinshankar the UI is approved in yesterday's EOD. You can merge it

@gigincg gigincg merged commit fb3937b into develop Jan 5, 2023
@rithviknishad rithviknishad mentioned this pull request Feb 7, 2023
41 tasks
@rithviknishad rithviknishad deleted the tailwind/slideover branch July 26, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications sidebar is not responsive
5 participants