Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: create asset asking to select a facility when viewing asset of filtered facility #4495

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jan 4, 2023

Bug Fix

Proposed Changes

  • Added filtered facility as the selected facility for creating asset

Associated Issue

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team January 4, 2023 08:57
@aeswibon aeswibon requested a review from a team as a code owner January 4, 2023 08:57
@aeswibon aeswibon requested a review from gigincg January 4, 2023 08:57
@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 2:22PM (UTC)

@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c7bce0e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63eb9892df518a0008d1b2d6
😎 Deploy Preview https://deploy-preview-4495--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-Coder the issue is still not solved. it's still asking for facility

@aeswibon
Copy link
Member Author

aeswibon commented Jan 5, 2023

@rithviknishad can you attach a video where the problem is still persist. I am not able to find it in the deployed preview.

@rithviknishad
Copy link
Member

@cp-Coder the pop-up dialogue is an unnecessary step present if we are viewing assets after landing from the facility home page.

cc: @nihal467

out.mp4

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 13, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@nihal467
Copy link
Member

@cp-Coder
image

when we apply the filter and click create an asset. Even though, the pop-up is not showing up, but unable to make a asset

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon aeswibon added needs testing and removed waiting for backend merge conflict pull requests with merge conflict labels Feb 3, 2023
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Feb 3, 2023
@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 053e542
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63dcdcc732a4d40008ce10b3

@nihal467
Copy link
Member

nihal467 commented Feb 7, 2023

LGTM

@khavinshankar
Copy link
Member

@rithviknishad can you rereview this

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I don't see the localizations which were added being used anywhere
  2. Keys must be snake_case

cc: @khavinshankar

@khavinshankar
Copy link
Member

@cp-Coder can you work on @rithviknishad's comments

@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@cp-Coder is it good for testing

@rithviknishad
Copy link
Member

@nihal467 only unused localizations were removed. Good to be merged since it's already been tested.

cc: @khavinshankar

@khavinshankar khavinshankar merged commit d98e253 into ohcnetwork:develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants