-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: create asset asking to select a facility when viewing asset of filtered facility #4495
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cp-Coder the issue is still not solved. it's still asking for facility
@rithviknishad can you attach a video where the problem is still persist. I am not able to find it in the deployed preview. |
@cp-Coder the pop-up dialogue is an unnecessary step present if we are viewing assets after landing from the facility home page. cc: @nihal467 out.mp4 |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr. |
👋 Hi, @cp-Coder, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
❌ Deploy Preview for care-net failed.
|
LGTM |
@rithviknishad can you rereview this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I don't see the localizations which were added being used anywhere
- Keys must be
snake_case
cc: @khavinshankar
@cp-Coder can you work on @rithviknishad's comments |
Kudos, SonarCloud Quality Gate passed!
|
@cp-Coder is it good for testing |
@nihal467 only unused localizations were removed. Good to be merged since it's already been tested. cc: @khavinshankar |
Bug Fix
Proposed Changes
Associated Issue
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist