Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Health details to COVID Details and Medical history (comorbidities) #4502

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Fix: Health details to COVID Details and Medical history (comorbidities) #4502

merged 2 commits into from
Jan 6, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jan 4, 2023

Bug Fix

Proposed Changes

  • Updated Health Details section and re-ordered the section
  • Updated Medical History section and added NONE as medical history option

Associated Issue

Screenshots

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team January 4, 2023 10:26
@aeswibon aeswibon requested a review from a team as a code owner January 4, 2023 10:26
@aeswibon aeswibon added needs testing P1 breaking issue or vital feature urgent labels Jan 4, 2023
@vercel
Copy link

vercel bot commented Jan 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 0:21AM (UTC)

@netlify
Copy link

netlify bot commented Jan 4, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 31afc75
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b6c01fc267ec000907aa06
😎 Deploy Preview https://deploy-preview-4502--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Jan 5, 2023 •
edited by aeswibon
Loading

@cp-Coder

image

  • as per issue, if the patient is vaccinated, the number of doses is a mandatory field, incase someone submits without filling it, there should be an error notification under the field ( vaccine name, last date of vaccination ), similar to the local body, etc...

image

https://deploy-preview-4502--care-net.netlify.app/facility/a31e6a24-0146-4043-b295-3a6c2fe7e095/patient/a709c84e-28e8-41ee-bf5e-f7beb7e859f3/update

  • as per issue, for the existing records, if no medical records are selected, it may be by default selected as none

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Jan 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 8aaac9f into coronasafe:develop Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Medical History (Comorbidities) Health details to COVID Details
3 participants
@aeswibon @nihal467 @khavinshankar