Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Discharging patients #4573

Merged
merged 2 commits into from
Jan 15, 2023
Merged

fix: Discharging patients #4573

merged 2 commits into from
Jan 15, 2023

Conversation

aeswibon
Copy link
Member

Bug Fix

Proposed Changes

  • Added new fields for recovered and expired discharged patient

Associated Issue

Associated PRs

Screenshot

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team January 13, 2023 03:21
@aeswibon aeswibon requested a review from a team as a code owner January 13, 2023 03:21
@aeswibon aeswibon added waiting for backend waiting for related PR a co-related detail PR is under construction labels Jan 13, 2023
@vercel
Copy link

vercel bot commented Jan 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 14, 2023 at 2:42PM (UTC)

@netlify
Copy link

netlify bot commented Jan 13, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 75df85a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63c2beb79459290008a85d8c
😎 Deploy Preview https://deploy-preview-4573--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Jan 13, 2023 •
edited by aeswibon
Loading

@cp-Coder
image

  • the medicine applied is not fully visible

image

  • the buttons are overlapping with the data

image

  • add a validator, if the mandatory field is empty

@aparnacoronasafe
Copy link
Member

The above issues pointed out by Nihal need to be fixed before deploying. This doesn't meet our quality expectation

@aparnacoronasafe
Copy link
Member

A few more changes would be nice in this. Only for the form when "Recovered" is selected.

  1. Rename "Prescription medication" to "Discharge Prescription"
  2. Change the order to "Reason for discharge", "Discharge Date", "Discharge Prescription including PRN" and "Discharge advice"

@netlify
Copy link

netlify bot commented Jan 14, 2023

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 8d22ab9
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63c23dd8948f71000ab5aa4b

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jan 14, 2023
@nihal467
Copy link
Member

nihal467 commented Jan 14, 2023 •
edited
Loading

@cp-Coder @khavinshankar @gigincg the deployment is failed, check it

@aeswibon aeswibon removed the Deploy-Failed Deplyment is not showing preview label Jan 14, 2023
@aeswibon aeswibon added urgent needs testing P1 breaking issue or vital feature and removed waiting for backend waiting for related PR a co-related detail PR is under construction labels Jan 14, 2023
@nihal467
Copy link
Member

nihal467 commented Jan 14, 2023 •
edited
Loading

@cp-Coder

image

unable to discharge a patient

@aeswibon
Copy link
Member Author

@nihal467 Fixed it

@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 8107fe9 into ohcnetwork:develop Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discharging patients
4 participants
@aeswibon @nihal467 @aparnacoronasafe @khavinshankar