Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Page Component to make padding across pages to be consistent #4584

Closed
wants to merge 5 commits into from

Conversation

GokulramGHV
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@GokulramGHV GokulramGHV requested a review from a team January 14, 2023 10:00
@GokulramGHV GokulramGHV requested a review from a team as a code owner January 14, 2023 10:00
@vercel
Copy link

vercel bot commented Jan 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 22, 2023 at 0:02AM (UTC)

@netlify
Copy link

netlify bot commented Jan 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3edae85
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63cd25343e1e0e0008c0434c
😎 Deploy Preview https://deploy-preview-4584--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 14, 2023

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 040a286
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63c27d3b35be7d00098b85ff

@github-actions
Copy link

👋 Hi, @GokulramGHV,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 16, 2023
@GokulramGHV GokulramGHV removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict labels Jan 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@github-actions
Copy link

👋 Hi, @GokulramGHV,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GokulramGHV this would be hard to review + I'm pretty sure the merge conflicts would never settle for this PR since there'll always be PRs that'll be modifying the contents of the children of the page.

Ideally what should have been done is, to implement the Page component in one PR and use it in one place so that it can be tested. Once tested and merged, make multiple parallel PRs that use the new Page component for all the different pages.

This would be easier to review + easier to deal with merge conflicts.

cc: @khavinshankar

@GokulramGHV
Copy link
Member Author

@rithviknishad Hey, that's actually a great idea! I'll close this pr and make a new one just with the Page component implemented in one of the pages.

@GokulramGHV GokulramGHV closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Page component to make padding across pages consistent
2 participants