Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor UI fixes #4603

Merged
merged 4 commits into from
Feb 3, 2023
Merged

fix: Minor UI fixes #4603

merged 4 commits into from
Feb 3, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jan 15, 2023 •
edited
Loading

Bug Fix

Proposed Changes

  • Updated error message for date of test result
  • Added variant=danger to confirm button for Delete Asset operation
  • Updated redirected url from /asset/:assetID to /facility/:facilityID/asset/:assetID after scanning QR code
  • Added FacilitySelectDialog on clicking Import/Export button when no facility is selected

Associated Issue

Screenshot

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Jan 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 29, 2023 at 8:49AM (UTC)

@netlify
Copy link

netlify bot commented Jan 15, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3568a70
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63d632ae0765850008f31cfa
😎 Deploy Preview https://deploy-preview-4603--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aeswibon aeswibon marked this pull request as ready for review January 15, 2023 18:36
@aeswibon aeswibon requested a review from a team January 15, 2023 18:36
@aeswibon aeswibon requested a review from a team as a code owner January 15, 2023 18:36
@aeswibon aeswibon requested a review from bodhish January 15, 2023 18:36
@nihal467
Copy link
Member

@cp-Coder
image

image

  • in the responsive view of the delete asset pop-up, make the button in uniform size

@nihal467
Copy link
Member

@cp-Coder
image

the QR code scanner is not working

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 27, 2023
@github-actions
Copy link

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon aeswibon removed the merge conflict pull requests with merge conflict label Jan 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aeswibon
Copy link
Member Author

@Nihal the QR scanner code is working fine.
I have tested the QR code having the URL type https://status.10bedicu.org/karnataka?asset=1242142412424124124 and it is working. Please post the QR code and type of URL on which the scanner is not working.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 8b60fb8 into coronasafe:develop Feb 3, 2023
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
@aeswibon @rabilrbl
fix: Minor UI fixes (#4603)
72d549d 
* fix(patient): updated min error message for date of test result

* fix(asset): updated redirected url after scanning QR code

* fix(asset): replaced disabled with FacilitySelectDialog feature for Import/Export button

* fix(patient): prevent form submission on incorrect date_of_result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
3 participants
@aeswibon @nihal467 @khavinshankar