Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minor bugs in consultation form #4612

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jan 16, 2023

Bug Fix

Proposed Changes

  • For PRN Prescripion module:
    1. Enabled auto-scrolling in case of an error
    2. Added red astrix to the Medicine and Indicator fields
    3. Updated error message to include specific field errors
  • For Procedure module:
    1. Enabled auto-scrolling in case of an error
    2. Added red astrix to the Procedure and Time/Frequency fields
    3. Updated error message to include specific field errors
  • For Investigation module:
    1. Removed default Nothing selected Text
    2. Added red astrix to the Investigation Recommended and Time/Frequency fields
    3. Updated error message to include specific field errors
  • Moved Procedure module below PRN Prescription module

Associated Issue

Screenshot

image
image
image

image
image
image
image
image

image
image
image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Jan 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 0:28AM (UTC)

@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4795a70
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63ca885622cc0d0009ef7c10
😎 Deploy Preview https://deploy-preview-4612--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aeswibon aeswibon marked this pull request as ready for review January 16, 2023 10:23
@aeswibon aeswibon requested a review from a team January 16, 2023 10:23
@aeswibon aeswibon requested a review from a team as a code owner January 16, 2023 10:23
@nihal467
Copy link
Member

nihal467 commented Jan 17, 2023

@cp-Coder
https://deploy-preview-4612--care-net.netlify.app/facility/d1649863-471c-4f6c-841a-67885ebdefe6/patient/309a55ae-3c0a-404b-900c-31cc20717445/consultation/59490b85-7149-48a2-9b00-7aa113cdc477/medicines

as per issue #3935 , the procedure filled inside the consultation form should be reflected in the medicine section under the PRN Prescription, but it's been missing in your PR, push fix ASAP

image

@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit dd30987 into ohcnetwork:develop Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants