Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves Ordering Filter out of Advanced Filters #4622

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Moves Ordering Filter out of Advanced Filters #4622

merged 2 commits into from
Jan 23, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team January 17, 2023 13:59
@rithviknishad rithviknishad requested a review from a team as a code owner January 17, 2023 13:59
@vercel
Copy link

vercel bot commented Jan 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 6:11AM (UTC)

@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1746aae
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63c78d20d747be0008b5f15e
😎 Deploy Preview https://deploy-preview-4622--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Jan 22, 2023 •
edited
Loading

LGTM @rithviknishad check the cypress failed

@rithviknishad
Copy link
Member Author

@nihal467 @khavinshankar cypress failing for things out of scope of this PR
image

@khavinshankar khavinshankar merged commit 5aa8ed5 into develop Jan 23, 2023
@rithviknishad rithviknishad deleted the filters/sorting branch July 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move sorting filter out of advanced filters
3 participants
@rithviknishad @nihal467 @khavinshankar