Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max height limit on facility card #4632

Merged
merged 7 commits into from
Feb 2, 2023

Conversation

Pranshu1902
Copy link
Contributor

Fixes #4625
Added max-height limit
Before:
image

After:
image

@Pranshu1902 Pranshu1902 requested a review from a team January 18, 2023 13:22
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner January 18, 2023 13:22
@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0af3af9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63d94da7f71bca000813f3e4
😎 Deploy Preview https://deploy-preview-4632--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 5:22PM (UTC)

@nihal467
Copy link
Member

@Pranshu1902
image

in the responsive, all the datas are not visible

@Pranshu1902
Copy link
Contributor Author

@nihal467
Updated view:
image

Desktop view:
image

@nihal467
Copy link
Member

@Pranshu1902
image

the card buttons are not properly placed

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Pranshu1902
Copy link
Contributor Author

@nihal467 Updated view:
image

@nihal467
Copy link
Member

nihal467 commented Feb 1, 2023

LGTM

@khavinshankar khavinshankar merged commit 0df22a1 into coronasafe:develop Feb 2, 2023
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
* added max height limit

* enhanced view

* debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility card is having excess whitespace for random rows of cards
3 participants